Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predeploy more resources #5

Draft
wants to merge 24 commits into
base: upstream-clone
Choose a base branch
from
Draft

Predeploy more resources #5

wants to merge 24 commits into from
+102 −41

Commits on Nov 23, 2024

  1. Allow to recognize the predeployed annotation

    @oct8l
    oct8l committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    737574c View commit details
    Browse the repository at this point in the history

  2. Allow the mock resource to be designated as predeployed

    @oct8l
    oct8l committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    4cc4e62 View commit details
    Browse the repository at this point in the history

  3. Fix logic in deciding if something should be predeployed

    @oct8l
    oct8l committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    a075097 View commit details
    Browse the repository at this point in the history

  4. Add functionality in the discovery to respect the predeployed annotation

    @oct8l
    oct8l committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    8746eb1 View commit details
    Browse the repository at this point in the history

  5. Add Deployments, Services and Jobs to be deployed after CRs

    @oct8l
    oct8l committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    f4e0385 View commit details
    Browse the repository at this point in the history

  6. Fix a couple tests to be up to speed with the new functionality

    @oct8l
    oct8l committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    9c539c9 View commit details
    Browse the repository at this point in the history

  7. Change test to work now that Services can be predeployed

    @oct8l
    oct8l committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    d70bd2d View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Add information to the README about resources that can be marked as '… 

    …predeployed'
    @c-gerke
    c-gerke committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    ca20352 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Also allow Ingresses to respect the 'predeployed' annotation

    @c-gerke
    c-gerke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    5b45f3b View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2024

  1. Remove duplicate 'kind' definition

    @c-gerke
    c-gerke committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    52a608d View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Refactor predeploy logic and enhance resource handling 

    - Updated `predeploy_sequence` to specify resource groups for better clarity.
- Modified `predeployed?` method logic to allow for default behavior based on resource type.
- Introduced `default_to_predeployed?` method in multiple resource classes to standardize predeployment behavior.
- Removed redundant `predeployed?` methods from `Deployment`, `Job`, and `Service` classes.
- Added debug logging in integration tests for better traceability of resource groups during deployment.
    @c-gerke
    c-gerke committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c598e1e View commit details
    Browse the repository at this point in the history

  2. Explicitly set the priority resources to be predeployed

    @c-gerke
    c-gerke committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    873c050 View commit details
    Browse the repository at this point in the history

  3. Clean up (now) unused definitions

    @c-gerke
    c-gerke committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    876715a View commit details
    Browse the repository at this point in the history

  4. Add more resources to the 'after_crs' section of pre-deployment

    @c-gerke
    c-gerke committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    2f88b93 View commit details
    Browse the repository at this point in the history

  5. Documentation updates

    @c-gerke
    c-gerke committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    3af0df3 View commit details
    Browse the repository at this point in the history

  6. Remove a missed definition

    @c-gerke
    c-gerke committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    f873ef1 View commit details
    Browse the repository at this point in the history

  7. Revert change to force Role and RoleBinding to be predeployed at the … 

    …resource level
    @c-gerke
    c-gerke committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    042fc44 View commit details
    Browse the repository at this point in the history

  8. Allow CR to be set to predeployed independent of CRDs

    @c-gerke
    c-gerke committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    bd5bc25 View commit details
    Browse the repository at this point in the history

  9. Fix line references that have changed

    @c-gerke
    c-gerke committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    8bbbe90 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. Quick and dirty fix to get tests and deployments working properly 

    This will be fixed later on, but getting a proposed version up in a PR to Shopify's Krane is the priority
    @c-gerke
    c-gerke committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    9839b6d View commit details
    Browse the repository at this point in the history

  2. Remove accidental newline

    @c-gerke
    c-gerke committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    bbc989f View commit details
    Browse the repository at this point in the history

  3. Refactor predeployed logic for Kubernetes resources 

    - Introduced a constant `PREDEPLOYED_RESOURCE_TYPES` to manage predeployed resource types.
- Updated `predeployed?` method to utilize the new constant for Role and RoleBinding checks.
- Removed redundant `predeployed?` methods from ConfigMap, NetworkPolicy, PersistentVolumeClaim, ResourceQuota, Role, RoleBinding, Secret, and ServiceAccount classes, simplifying their implementation.
- Set `default_to_predeployed?` to always return true in CustomResourceDefinition.
    @c-gerke
    c-gerke committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    6c4c6a9 View commit details
    Browse the repository at this point in the history

  4. Move pod predeploy logic with the rest of the "required to predeploy"… 

    … resources
    @c-gerke
    c-gerke committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    5016db4 View commit details
    Browse the repository at this point in the history

  5. Remove the default_to_predeployed function from previous iterations… 

    … on this PR

Also add CRDs and CRs to their previous functionality, not using the `default_to_predeployed` functionality
    @c-gerke
    c-gerke committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    bfd40a7 View commit details
    Browse the repository at this point in the history