Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-48]Configure the Date Picker Kit to be able to select month only as an option #1735

Merged
merged 6 commits into from
Jan 27, 2022
Merged

[PLAY-48]Configure the Date Picker Kit to be able to select month only as an option #1735

merged 6 commits into from
Jan 27, 2022

Conversation

JelenaD1
Copy link
Contributor

@JelenaD1 JelenaD1 commented Jan 22, 2022 •
edited
Loading

Screens

Playbook_Design_System

Breaking Changes

No. This change is configuring Date Picker kit, using flatpickr library. Setting plugins prop to true, month&year only calendar will be activated. This calendar option is also configured to allow using flatpickr hooks and events.

Runway Ticket URL

https://nitro.powerhrg.com/runway/backlog_items/PLAY-48

How to test this

Set plugins prop to true and Date Picker kit will display the calendar.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@JelenaD1 JelenaD1 requested a review from a team as a code owner January 22, 2022 23:26
@JelenaD1 JelenaD1 self-assigned this Jan 22, 2022
@JelenaD1 JelenaD1 added enhancement New Features, Props, & Variants (USED IN CHANGELOG) wip milano 20 MAX - Deploy this PR to a review environment via Milano labels Jan 22, 2022
@app-milano app-milano bot temporarily deployed to pr1735 January 22, 2022 23:46 Inactive
@JelenaD1 JelenaD1 added improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) and removed wip labels Jan 23, 2022
@app-milano app-milano bot temporarily deployed to pr1735 January 23, 2022 01:25 Inactive
@app-milano app-milano bot temporarily deployed to pr1735 January 23, 2022 02:08 Inactive
@app-milano app-milano bot temporarily deployed to pr1735 January 24, 2022 21:18 Inactive
@app-milano app-milano bot temporarily deployed to pr1735 January 25, 2022 20:44 Inactive
@app-milano app-milano bot temporarily deployed to pr1735 January 27, 2022 16:19 Inactive
thestephenmarshall
thestephenmarshall approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@thestephenmarshall thestephenmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@JelenaD1 JelenaD1 merged commit f3ed7c0 into master Jan 27, 2022
@JelenaD1 JelenaD1 deleted the PCA/Date-picker-kit-config branch January 27, 2022 21:52
RobGentile17 pushed a commit that referenced this pull request Feb 2, 2022
@JelenaD1 @RobGentile17
[PLAY-48]Configure the Date Picker Kit to be able to select month onl…
7ff56ff 
…y as an option (#1735)

* React code done

* Change prop name/added rails code

* hallelujah

* clean code

* Fixed styles

* fixed hover color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

Assignees

@JelenaD1 JelenaD1

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JelenaD1 @thestephenmarshall @jasoncypret