Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-52]Remove div wrapping Image kit #1737

Merged
merged 2 commits into from
Jan 28, 2022
Merged

[PLAY-52]Remove div wrapping Image kit #1737

merged 2 commits into from
Jan 28, 2022

Conversation

kyleschechter
Copy link
Contributor

@kyleschechter kyleschechter commented Jan 24, 2022 •
edited
Loading

Screens

image

image

image

image

image

Breaking Changes

Yes, the image kit came with a built in wrapper <div> so alpha testing is required to ensure that the styling of the pages using this kit are not altered.

Runway Ticket URL

https://nitro.powerhrg.com/runway/backlog_items/PLAY-52

How to test this

  1. Start up a server for nitro-web
  2. Create or view a react component that uses the Image kit
  3. Check to make sure that the image fits on the page correctly and looks the way it is anticipated to look

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@kyleschechter kyleschechter requested a review from a team as a code owner January 24, 2022 15:47
@kyleschechter kyleschechter self-assigned this Jan 24, 2022
@kyleschechter kyleschechter added improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) react needs alpha testing milano 20 MAX - Deploy this PR to a review environment via Milano labels Jan 24, 2022
@app-milano app-milano bot temporarily deployed to pr1737 January 24, 2022 16:10 Inactive
@app-milano app-milano bot temporarily deployed to pr1737 January 26, 2022 19:16 Inactive
@app-milano app-milano bot temporarily deployed to pr1737 January 26, 2022 20:51 Inactive
@thestephenmarshall thestephenmarshall force-pushed the Play-52-Remove-div-image-kit branch from 8cbd679 to 4ae59f5 Compare January 27, 2022 20:21
@kyleschechter kyleschechter merged commit 8303f2a into master Jan 28, 2022
@kyleschechter kyleschechter deleted the Play-52-Remove-div-image-kit branch January 28, 2022 16:41
RobGentile17 pushed a commit that referenced this pull request Feb 2, 2022
@kyleschechter @RobGentile17
[PLAY-52]Remove div wrapping Image kit (#1737)
940dbfa 
* Removed div and adjusted React docs

* Tweaked pb image docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

Assignees

@kyleschechter kyleschechter

Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano needs alpha testing Needs Review react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyleschechter @thestephenmarshall