Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-111] Size Prop styling needs to be corrected: Avatar #1758

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Feb 1, 2022

Screens

BEFORE
avatar_props_before

AFTER
Screen Shot 2022-02-01 at 11 07 22 AM

BELOW: ALL SCREENSHOTS ARE FROM ALPHA TEST

SALES REPS
Screen Shot 2022-02-03 at 1 13 47 PM

USER PROFILE
Screen Shot 2022-02-03 at 3 32 35 PM

POWER STORY
Screen Shot 2022-02-04 at 9 21 03 AM

RUNWAY
Screen Shot 2022-02-03 at 2 46 10 PM

Video Showcasing how adding a size props no longer changes that avatar kit size. Test done in alpha:

AvatarAlpha.mov

Breaking Changes

This will add word size on avatar kits but the actual size will remain the same. The only thing we need to do is make sure avatar kits with size on are not being targeted anywhere in Nitro so we can safely update the classname.

[Yes/No (Explain)]

Runway Ticket URL

[INSERT URL]

How to test this

Add a margin or padding prop to the avatar kit and see if image size will change.

[INSERT TESTING DETAILS]

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nickamantia nickamantia added the bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) label Feb 1, 2022
@nickamantia nickamantia requested a review from a team as a code owner February 1, 2022 16:31
@nickamantia nickamantia self-assigned this Feb 1, 2022
@nickamantia nickamantia added the milano 20 MAX - Deploy this PR to a review environment via Milano label Feb 1, 2022
Copy link
Contributor

@thestephenmarshall thestephenmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, let's alpha test this!

@nickamantia
Copy link
Contributor Author

nickamantia commented Feb 4, 2022

Alpha Testing looks good! Did not come across any missing or broken avatar kits. Added screenshots of different areas that I tested

@thestephenmarshall thestephenmarshall merged commit 3594c2c into master Feb 14, 2022
@thestephenmarshall thestephenmarshall deleted the play111-size-prop-avatar branch February 14, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants