Updates Visual Guidelines Color Partial to TSX #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed flow and Renamed file * Updated Types * Removed JSX file extentions from imports * Fix syntax error * Fix tests Co-authored-by: Erica Winne <[email protected]>
* Started Converting * Rename file to TSX and Updated types * Added/Joined & GlobalProps * Merge Master * Changed back default blank string Co-authored-by: Erica Winne <[email protected]>
GordonHodanich
added
milano
GordonHodanich
added
wip
and removed
milano
thestephenmarshall
force-pushed
the
master
branch
2 times, most recently
from
4755d3c
to
9a62f6e
Compare
GordonHodanich
force-pushed
the
Play/switch_color_partials_to_react
branch
from
8c5852e
to
9d27749
Compare
GordonHodanich
added
milano
thestephenmarshall
approved these changes
May 17, 2022
GordonHodanich
changed the title
thestephenmarshall
approved these changes
May 18, 2022
thestephenmarshall
approved these changes
May 23, 2022
thestephenmarshall
added
the
Ready for Release
thestephenmarshall
removed
the
milano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScreenShot:
Breaking Changes
No, reproduced the Visual Guidelines Color partial to be displayed in the
visual_guidelines_reactpageRunway Ticket URL
PLAY-164
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.