[Play 300] - Fix Global Responsive Props and Cleanup #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidaqg
added
enhancement
nidaqg
requested review from
thestephenmarshall,
augustomallmann,
jasperfurniss and
Israel-Molestina
jasoncypret
approved these changes
Sep 6, 2022
thestephenmarshall
approved these changes
Sep 7, 2022
jasperfurniss
approved these changes
Sep 9, 2022
jasperfurniss
added
the
Ready for Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Flex direction global prop showing up in DOM
Flex direction global prop in action (column for smaller screen size, row for larger size)
justifyContent global prop showing up in DOM
justifyContent set to 'end for xs-md screen sizes for testing, working well
Moved partials for flexbox global props to their own folder for better organization
Breaking Changes
No breaking changes, fixed broken props
Runway Ticket URL
Runway Story
How to test this
[INSERT TESTING DETAILS]
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.