Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-216] - TS Conversion of Date Stacked kit + Jest Test #2070

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Sep 14, 2022

Screens

Playbook-Design-System (8)

Breaking Changes

No breaking changes, converts Date Stacked Kit to Typescript and adds Jest test.

Runway Ticket URL

Runway Story

How to test this

Review in milano env. Navigate to date stacked kit and verify that all examples work as expected.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano typescript labels Sep 14, 2022
@nidaqg nidaqg requested a review from a team as a code owner September 14, 2022 15:48
@nidaqg nidaqg self-assigned this Sep 14, 2022
@app-milano app-milano bot temporarily deployed to pr2070 September 14, 2022 17:15 Inactive
@thestephenmarshall thestephenmarshall added Ready for Release merged to master, ready for a versioned released and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Sep 26, 2022
@jasperfurniss jasperfurniss merged commit ffd34d0 into master Sep 30, 2022
@jasperfurniss jasperfurniss deleted the PLAY-216-TS-conversion-date-stacked branch September 30, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) Ready for Release merged to master, ready for a versioned released typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants