Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-374]-Filter Kit Style Bleed Fix #2117

Merged
merged 1 commit into from
Oct 19, 2022
Merged

[PLAY-374]-Filter Kit Style Bleed Fix #2117

merged 1 commit into from
Oct 19, 2022

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Oct 10, 2022

Screens

Screen Shot 2022-10-10 at 4 51 57 PM

Breaking Changes

no, fixed style bleed from scss file

Runway Ticket URL

Runway Story

How to test this

Test in milano env

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 10, 2022
@nidaqg nidaqg self-assigned this Oct 10, 2022
@nidaqg nidaqg requested a review from a team as a code owner October 10, 2022 20:55
@jasperfurniss jasperfurniss merged commit 24a17b8 into master Oct 19, 2022
@jasperfurniss jasperfurniss deleted the PLAY-374-Filter-Kit-Style-Bleed branch October 19, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

@jasperfurniss jasperfurniss Awaiting requested review from jasperfurniss

Assignees

@nidaqg nidaqg

Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nidaqg @thestephenmarshall @jasperfurniss