Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-555] Fixed Body Content disappearing behind Footer for Dialog #2283

Merged
merged 3 commits into from
Feb 2, 2023
Merged

[PLAY-555] Fixed Body Content disappearing behind Footer for Dialog #2283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b78539d
Fixed issue with body content disappearing behind footer
nidaqg Jan 25, 2023
941aa05
Using pseudo div instead of padding to fix issue
nidaqg Feb 2, 2023
3cd69ab
Merge branch 'master' into Play-555-dialog-sticky-footer-issue
nidaqg Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions playbook/app/pb_kits/playbook/pb_dialog/_dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,11 @@
height: 100%;
max-height: 100%;
max-width: none;
//this empty div only has height when dialog is full height.
//fix for dialog body content disappearing behind sticky footer
.dialog-pseudo-footer {
height: $space_xl * 2;
}
.dialog_footer {
position:fixed;
bottom: 0;
Expand Down Expand Up @@ -287,6 +292,11 @@
height: 100% !important;
max-height: 100% !important;
max-width: 100%;
//this empty div only has height when dialog is full height.
//fix for dialog body content disappearing behind sticky footer
.dialog-pseudo-footer {
height: $space_xl * 2;
}
.dialog_footer {
position:fixed;
bottom: 0;
Expand Down
2 changes: 2 additions & 0 deletions playbook/app/pb_kits/playbook/pb_dialog/child_kits/_dialog_footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ const DialogFooter = (props: DialogFooterProps) => {
{separator &&
<SectionSeparator />
}
<div className="dialog-pseudo-footer">
</div>
<Flex
className={classnames(footerCSS, footerSpacing, className)}
spacing={spacing}
Expand Down
1 change: 1 addition & 0 deletions playbook/app/pb_kits/playbook/pb_dialog/dialog_footer.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
data: object.data,
aria: object.aria) do %>
<% if object.confirm_button && object.cancel_button %>
<div class="dialog-pseudo-footer"></div>
<%= pb_rails("flex", props: { classname:object.classname, spacing:"between", padding_x:"sm", padding:"sm", padding_bottom:"sm" }) do %>
<%= pb_rails("button", props: { type: "submit", id: object.confirm_button_id }) do %>
<%= object.confirm_button %>
Expand Down