[PLAY-575] Added Position Fixed to Rails Dialog #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidaqg
added
bug
jasperfurniss
approved these changes
Jan 27, 2023
nidaqg
added
Ready for Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Breaking Changes
No breaking change.
Runway Ticket URL
Runway Story
How to test this
Code only effects class wrapping the rails dialog kit, not react. Test all doc examples on rails dialog page in playbook to make sure change doesn't break anything. Fix however can only be tested in Nitro as the bug is coming from a CSS file in Nitro that is interfering with our styles.
Will update here will alpha review env once it is ready.
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.