[PLAY-729] 🛠️ Update Avatar kit imageAlt default #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is given by the user it defaults to the name provided
Israel-Molestina
added
enhancement
nidaqg
reviewed
Apr 12, 2023
playbook/app/pb_kits/playbook/pb_avatar/docs/_avatar_default.jsx
Outdated
Show resolved
Hide resolved
… to a ternary operation and uncommented out a line in the default doc example
nidaqg
approved these changes
Apr 12, 2023
nidaqg
added
the
Ready for Release
markdoeswork
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Runway Ticket
This PR reconfigured the way the alt attribute is passed into the Image kit from the Avatar kit. Previously it would use the prop
imageAltorimage_altto pass into the alt attribute. Therefore if a user did not pass in animageAltprop the alt attribute would be left empty. I've created a conditional that checks for animageAtlprop, if there is none, it passes thenameprop as the alt attribute.Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
imageAltprop being passes in the image has an alt attribute.Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.