[PLAY-739] Rebuild Getting Started #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustomallmann
added
milano
jasperfurniss
previously approved these changes
Apr 24, 2023
nidaqg
reviewed
Apr 24, 2023
playbook-website/app/views/pages/getting_started_partials/_react_getting_started.md
Outdated
Show resolved
Hide resolved
nidaqg
previously approved these changes
Apr 24, 2023
jasoncypret
requested changes
Apr 24, 2023
playbook-website/app/views/pages/getting_started/index.html.erb
Outdated
Show resolved
Hide resolved
jasperfurniss
previously approved these changes
Apr 24, 2023
**What does this PR do?** [Runway Ticket](https://nitro.powerhrg.com/runway/backlog_items/PLAY-400) * In this PR I've changed the prop on the Flex kit that holds the value and unit text from `vertical=bottom` to `align=baseline` so that the value and unit are aligned on the bottom **Screenshots:** Screenshots to visualize your addition/change #### Before <img width="186" alt="Screen Shot 2023-04-14 at 2 40 56 PM" src="https://user-images.githubusercontent.com/73671109/232129879-6885bf97-a122-4a12-9087-b68dd910e3dd.png"> #### After <img width="207" alt="Screen Shot 2023-04-14 at 2 38 15 PM" src="https://user-images.githubusercontent.com/73671109/232129909-eb1b2783-e720-418a-80d2-473649b89758.png"> **How to test?** Steps to confirm the desired behavior: 1. Go to the [Stat Icon Value](https://playbook.powerapp.cloud/kits/icon_stat_value/react) kit in playbook 2. Check all examples to make sure value and unit line up 3. Go to Nitro-web 4. Check for isntance of Icon Stat Value to see if we need an alpha to test how much this PR effects Nitro #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [ ] **TESTS** I have added test coverage to my code. Co-authored-by: Nida Ghuman <[email protected]>
**What does this PR do?** [Runway Ticket](https://nitro.powerhrg.com/runway/backlog_items/PLAY-730) * Adding `tr`, `td`, and `th` options for the `tag` props in the background kit. * This allows users to use the background kit in the table kit **Screenshots:** <img width="1398" alt="Screen Shot 2023-04-12 at 3 36 19 PM" src="https://user-images.githubusercontent.com/73671109/231565931-055d0b81-fdbc-4196-ae7a-255eea1b6c27.png"> **How to test?** Steps to confirm the desired behavior: 1. Go to the [Table Kit](https://playbook.powerapp.cloud/kits/table/react) in Playbook 2. Scroll down to the `TABLE WITH BACKGROUND KIT` section to see the new kit in action #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [x] **TESTS** I have added test coverage to my code. --------- Co-authored-by: Nida Ghuman <[email protected]>
**What does this PR do?** - Removing the max-width limitation on the input that causes layout and wiggle (when the selected country is changed) issues. - Removing Rails onChange and isValid props since they are not used on the Rails side and they are causing errors since they are null and we are trying to call these functions. **How to test?** Steps to confirm the desired behavior: 1. Go to Phone Number Input Kit 2. Check the Rails version if we are not getting errors when changing the country or typing a number #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [ ] **TESTS** I have added test coverage to my code. --------- Co-authored-by: Nida Ghuman <[email protected]>
**What does this PR do?** [Runway Ticket](https://nitro.powerhrg.com/runway/backlog_items/PLAY-701) * This PR adds two new color tokens. `$text_lt_success_sm` and `$text_dk_success_sm`. These are used for smaller text sizes. * I updated the Badge, Caption and Body kit to include these new text color variants. **Screenshots:** Screenshots to visualize your addition/change <img width="144" alt="Screen Shot 2023-04-13 at 3 07 47 PM" src="https://user-images.githubusercontent.com/73671109/231859061-10346123-dc4b-4e34-b326-a2362bfd5243.png"> <img width="142" alt="Screen Shot 2023-04-13 at 3 08 05 PM" src="https://user-images.githubusercontent.com/73671109/231859093-2f9d22be-1beb-439b-8b58-637c96feecbd.png"> <img width="151" alt="Screen Shot 2023-04-13 at 3 08 11 PM" src="https://user-images.githubusercontent.com/73671109/231859103-5726c170-89cf-4584-9932-e2b93a8532ac.png"> **How to test?** Steps to confirm the desired behavior: 1. Go to the Body, Caption and Badge kits in playbook 2. Inspect the page to check if the correct color hex value is being used for the success variants in both light and dark mode. #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [x] **TESTS** I have added test coverage to my code. --------- Co-authored-by: Nida Ghuman <[email protected]>
**What does this PR do?** Converting Table kit to Typescript. **How to test?** Steps to confirm the desired behavior: 1. Go to Table kit on Playbook docs 2. Ensure all the examples still work #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [ ] **TESTS** I have added test coverage to my code. --------- Co-authored-by: Nida Ghuman <[email protected]>
**What does this PR do?** A clear and concise description with your runway ticket url. Converts the `textarea.jsx` to typescript `textarea.tsx` and adds a test **Screenshots:** Screenshots to visualize your addition/change There are no visual changes **How to test?** Steps to confirm the desired behavior: 1. Go to http://127.0.0.1:3000/kits/textarea/react# 2. Test all of the examples on the page #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [x] **TESTS** I have added test coverage to my code. --------- Co-authored-by: Jasper Furniss <[email protected]>
**What does this PR do?** Serve Proxima Nova font to our Sandpack instances, so that our Sandpack doc examples' fonts align with Playbook's theme. **How to test?** Steps to confirm the desired behavior: 1. Go to kit/sandpack 2. Check that the kit is using Proxima Nova. #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [ ] **TESTS** I have added test coverage to my code. --------- Co-authored-by: Jasper Furniss <[email protected]> Co-authored-by: Jasper Furniss <[email protected]> Co-authored-by: Nida Ghuman <[email protected]>
**What does this PR do?** A clear and concise description with your runway ticket url. **Screenshots:** Screenshots to visualize your addition/change **How to test?** Steps to confirm the desired behavior: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See addition/change #### Checklist: - [ ] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [ ] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [ ] **TESTS** I have added test coverage to my code.
jasperfurniss
force-pushed
the
play-739-rebuild-getting-started
branch
from
8f6f104
to
e678c52
Compare
jasperfurniss
approved these changes
Apr 24, 2023
jasoncypret
approved these changes
Apr 24, 2023
jasperfurniss
added a commit
that referenced
this pull request
Apr 26, 2023
<img width="1726" alt="Screenshot 2023-04-19 at 2 29 35 PM" src="https://user-images.githubusercontent.com/8194056/233167385-e618aed1-bb3a-4a08-8ac3-087fb2559db0.png"> **How to test?** Steps to confirm the desired behavior: Go to the `/getting_started` page, check its content. Click on all the links available on the page and check the design and content. #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [ ] **TESTS** I have added test coverage to my code. --------- Co-authored-by: Israel Molestina <[email protected]> Co-authored-by: Nida Ghuman <[email protected]> Co-authored-by: Carlos Lima <[email protected]> Co-authored-by: Mark Rosenberg <[email protected]> Co-authored-by: Jasper Furniss <[email protected]> Co-authored-by: Jasper Furniss <[email protected]>
nidaqg
added a commit
that referenced
this pull request
Apr 27, 2023
<img width="1726" alt="Screenshot 2023-04-19 at 2 29 35 PM" src="https://user-images.githubusercontent.com/8194056/233167385-e618aed1-bb3a-4a08-8ac3-087fb2559db0.png"> **How to test?** Steps to confirm the desired behavior: Go to the `/getting_started` page, check its content. Click on all the links available on the page and check the design and content. #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [ ] **TESTS** I have added test coverage to my code. --------- Co-authored-by: Israel Molestina <[email protected]> Co-authored-by: Nida Ghuman <[email protected]> Co-authored-by: Carlos Lima <[email protected]> Co-authored-by: Mark Rosenberg <[email protected]> Co-authored-by: Jasper Furniss <[email protected]> Co-authored-by: Jasper Furniss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test? Steps to confirm the desired behavior:
Go to the
/getting_startedpage, check its content. Click on all the links available on the page and check the design and content.Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.