Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken datepicker page #2496

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Apr 26, 2023

What does this PR do? A clear and concise description with your runway ticket url.

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nidaqg nidaqg added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Apr 26, 2023
@nidaqg nidaqg self-assigned this Apr 26, 2023
@nidaqg nidaqg requested a review from a team as a code owner April 26, 2023 20:00
@app-milano app-milano bot temporarily deployed to pr2496 April 26, 2023 20:18 Inactive
@jasperfurniss jasperfurniss added this pull request to the merge queue Apr 27, 2023
Merged via the queue into master with commit 0a07bfa Apr 27, 2023
@jasperfurniss jasperfurniss deleted the remove-popover-from-copy-button branch April 27, 2023 13:08
nidaqg added a commit that referenced this pull request Apr 27, 2023
**What does this PR do?** A clear and concise description with your
runway ticket url.


**Screenshots:** Screenshots to visualize your addition/change


**How to test?** Steps to confirm the desired behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See addition/change


#### Checklist:
- [ ] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new
kit`, `deprecated`, or `breaking`. See [Changelog &
Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels)
for details.
- [ ] **DEPLOY** I have added the `milano` label to show I'm ready for a
review.
- [ ] **TESTS** I have added test coverage to my code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants