Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-807] Created extensions prop For advanced RTE #2560

Merged
merged 10 commits into from
May 18, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented May 16, 2023

What does this PR do? A clear and concise description with your runway ticket url.

This PR adds a new prop called moreExtensions to the advanced variant of the RTE to allows devs to be able to add as many extensions they want to the editor and hav e the button show up in the ellipsis dropdown.

RUNWAY STORY

Screenshots: Screenshots to visualize your addition/change

Screenshot 2023-05-17 at 5 40 37 PM

How to test? Steps to confirm the desired behavior:

  1. Scroll down to the Advanced (More Extensions) doc example.
  2. Click the ellipsis drowpdown to see the menu.

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels May 16, 2023
@nidaqg nidaqg self-assigned this May 16, 2023
@nidaqg nidaqg changed the title Created moreExtensions prop to allow user to add to toolbar [PLAY-807] Created moreExtensions prop For advanced RTE May 16, 2023
@app-milano app-milano bot temporarily deployed to pr2560 May 16, 2023 13:11 Inactive
@app-milano app-milano bot temporarily deployed to pr2560 May 17, 2023 16:34 Inactive
@nidaqg nidaqg changed the title [PLAY-807] Created moreExtensions prop For advanced RTE [PLAY-807] Created extensions prop For advanced RTE May 17, 2023
@nidaqg nidaqg marked this pull request as ready for review May 17, 2023 17:23
@nidaqg nidaqg requested a review from a team as a code owner May 17, 2023 17:23
@app-milano app-milano bot temporarily deployed to pr2560 May 17, 2023 17:26 Inactive
@app-milano app-milano bot temporarily deployed to pr2560 May 17, 2023 18:29 Inactive
@app-milano app-milano bot temporarily deployed to pr2560 May 17, 2023 20:40 Inactive
@app-milano app-milano bot temporarily deployed to pr2560 May 17, 2023 22:02 Inactive
jasperfurniss
jasperfurniss previously approved these changes May 18, 2023
@nidaqg nidaqg added the alpha label May 18, 2023
@github-actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 12.21.0.pre.alpha.PLAY807RTEcustomtoolbar680

Your Alpha for NPM is 12.21.0-alpha.PLAY807RTEcustomtoolbar680

@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label May 18, 2023
@nidaqg nidaqg added this pull request to the merge queue May 18, 2023
Merged via the queue into master with commit d1bafe7 May 18, 2023
@nidaqg nidaqg deleted the PLAY-807-RTE-custom-toolbar branch May 18, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants