-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAY-807] Created extensions prop For advanced RTE #2560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidaqg
added
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
milano
20 MAX - Deploy this PR to a review environment via Milano
labels
May 16, 2023
nidaqg
changed the title
Created moreExtensions prop to allow user to add to toolbar
[PLAY-807] Created moreExtensions prop For advanced RTE
May 16, 2023
nidaqg
changed the title
[PLAY-807] Created moreExtensions prop For advanced RTE
[PLAY-807] Created extensions prop For advanced RTE
May 17, 2023
playbook/app/pb_kits/playbook/pb_rich_text_editor/TipTap/MoreExtensionsDropdown.tsx
Outdated
Show resolved
Hide resolved
jasperfurniss
previously approved these changes
May 18, 2023
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 12.21.0.pre.alpha.PLAY807RTEcustomtoolbar680 Your Alpha for NPM is 12.21.0-alpha.PLAY807RTEcustomtoolbar680 |
jasperfurniss
approved these changes
May 18, 2023
jasperfurniss
added
the
Ready for Release
merged to master, ready for a versioned released
label
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alpha
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
milano
20 MAX - Deploy this PR to a review environment via Milano
Ready for Release
merged to master, ready for a versioned released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
This PR adds a new prop called
moreExtensions
to the advanced variant of the RTE to allows devs to be able to add as many extensions they want to the editor and hav e the button show up in the ellipsis dropdown.RUNWAY STORY
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior: