Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-871] MultiSelect Rails #2590

Merged
merged 70 commits into from
Jun 27, 2023
Merged

[PLAY-871] MultiSelect Rails #2590

merged 70 commits into from
Jun 27, 2023

Conversation

jasperfurniss
Copy link
Contributor

@jasperfurniss jasperfurniss commented Jun 6, 2023 •
edited
Loading

What does this PR do?
This helps the rails multi_level_select correctly submit with forms.

How to test? Steps to confirm the desired behavior:

  1. Go to /multi_level_select/rails
  2. Scroll to the 3rd example
  3. Test form submission (ignore after URL - this will be set by the client)
  4. Click on the network tab, to find the data submitted correctly! 🎉

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@jasperfurniss jasperfurniss requested a review from a team as a code owner June 6, 2023 21:24
@jasperfurniss jasperfurniss self-assigned this Jun 6, 2023
@jasperfurniss jasperfurniss added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano alpha labels Jun 6, 2023
@app-milano app-milano bot temporarily deployed to pr2590 June 6, 2023 21:46 Inactive
@powerhome powerhome deleted a comment from github-actions bot Jun 7, 2023
@jasperfurniss jasperfurniss added alpha and removed alpha labels Jun 7, 2023
@jasperfurniss jasperfurniss added alpha and removed alpha labels Jun 26, 2023
@github-actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 12.26.1.pre.alpha.railsmultilevelimprovements837

Your Alpha for NPM is 12.26.1-alpha.railsmultilevelimprovements837

@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jun 27, 2023
@jasperfurniss jasperfurniss added milano 20 MAX - Deploy this PR to a review environment via Milano alpha and removed milano 20 MAX - Deploy this PR to a review environment via Milano alpha labels Jun 27, 2023
@github-actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 12.26.1.pre.alpha.railsmultilevelimprovements842

Your Alpha for NPM is 12.26.1-alpha.railsmultilevelimprovements842

@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jun 27, 2023
@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jun 27, 2023
@app-milano app-milano bot temporarily deployed to pr2590 June 27, 2023 18:28 Inactive
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Jun 27, 2023
@nidaqg nidaqg added this pull request to the merge queue Jun 27, 2023
Merged via the queue into master with commit 0ec4192 Jun 27, 2023
@nidaqg nidaqg deleted the rails-multilevel-improvements branch June 27, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidaqg nidaqg nidaqg approved these changes

@thestephenmarshall thestephenmarshall thestephenmarshall left review comments

Assignees

@jasperfurniss jasperfurniss

Labels
alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasperfurniss @thestephenmarshall @nidaqg