Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-78] 🐞🅿️ Select kit multiple is broken #2701

Merged
merged 14 commits into from
Aug 17, 2023

Conversation

Israel-Molestina
Copy link
Contributor

@Israel-Molestina Israel-Molestina commented Aug 15, 2023

What does this PR do? A clear and concise description with your runway ticket url.

Screenshots: Screenshots to visualize your addition/change
Screenshot 2023-08-15 at 10 42 21 AM

How to test? Steps to confirm the desired behavior:

  1. Go to the select component in the playbook website
  2. Scroll down to the multiple variant
  3. See addition

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@Israel-Molestina Israel-Molestina added the bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) label Aug 15, 2023
@Israel-Molestina Israel-Molestina self-assigned this Aug 15, 2023
@Israel-Molestina Israel-Molestina requested a review from a team as a code owner August 15, 2023 14:35
@Israel-Molestina Israel-Molestina added the milano 20 MAX - Deploy this PR to a review environment via Milano label Aug 15, 2023
@app-milano app-milano bot temporarily deployed to pr2701 August 15, 2023 20:15 Inactive
markdoeswork
markdoeswork previously approved these changes Aug 15, 2023
Copy link
Contributor

@markdoeswork markdoeswork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on adding examples and test!

@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-78-select-kit-multiple-prop

@github-actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 12.38.0.pre.alpha.PBNTR78selectkitmultipleprop1094

Your Alpha for NPM is 12.38.0-alpha.PBNTR78selectkitmultipleprop1094

@app-milano app-milano bot temporarily deployed to pr2701 August 17, 2023 19:07 Inactive
jasperfurniss
jasperfurniss previously approved these changes Aug 17, 2023
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Aug 17, 2023
@nidaqg nidaqg added this pull request to the merge queue Aug 17, 2023
Merged via the queue into master with commit 0ae4b47 Aug 17, 2023
1 check passed
@nidaqg nidaqg deleted the PBNTR-78-select-kit-multiple-prop branch August 17, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants