Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-932] Remove Moment Packages and Update Date Picker's Quick Pick Variants #2707

Merged
merged 17 commits into from
Aug 22, 2023
Merged

[PLAY-932] Remove Moment Packages and Update Date Picker's Quick Pick Variants #2707

merged 17 commits into from
Aug 22, 2023

Conversation

gavhuang
Copy link
Contributor

What does this PR do?

  • Runway
  • Remove moment packages and usage within quickPick.tsx and date_picker.test.js
  • ESLint: Remove "moment" as restricted global variable
  • Create implementations of the date range functionality that moment used to provide:
    • ex. Yesterday, This Week, This Quarter, Last Week, ...and so on

How to test? Steps to confirm the desired behavior:

  1. Go to the docs page
  2. Go to the Date Picker kit and test both Quick Pick variants

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@gavhuang gavhuang added deprecated Use this label when you have removed or plan to remove kits or props. (USED IN CHANGELOG) breaking Indicates that a breaking change was introduced (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano alpha labels Aug 17, 2023
@gavhuang gavhuang requested a review from a team as a code owner August 17, 2023 16:30
@gavhuang gavhuang self-assigned this Aug 17, 2023
@github-actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 12.38.0.pre.alpha.PLAY932removemomentqp1088

Your Alpha for NPM is 12.38.0-alpha.PLAY932removemomentqp1088

@app-milano app-milano bot temporarily deployed to pr2707 August 17, 2023 16:46 Inactive
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Aug 22, 2023
@jasperfurniss jasperfurniss added this pull request to the merge queue Aug 22, 2023
Merged via the queue into master with commit 350784e Aug 22, 2023
2 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-932-remove-moment-qp branch August 22, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@gavhuang gavhuang

Labels
alpha breaking Indicates that a breaking change was introduced (USED IN CHANGELOG) deprecated Use this label when you have removed or plan to remove kits or props. (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavhuang @jasperfurniss @nidaqg