Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-95] Make style improvements #2766

Merged
merged 15 commits into from
Sep 29, 2023

Conversation

markdoeswork
Copy link
Contributor

@markdoeswork markdoeswork commented Sep 27, 2023

What does this PR do? A clear and concise description with your runway ticket url.
Runway: https://nitro.powerhrg.com/runway/backlog_items/PBNTR-95

Feedback provided for a Nitro PR, but the changes need to be made in playbook
Nitro review env: https://pr34778.nitro-web.beta.px.powerapp.cloud/project_surveys/surveys?mt=Customer+Survey+Results
Nitro Web PR: https://github.com/powerhome/nitro-web/pull/34778

Updated the Nav kit to hide the left border indicator when active with the active_indicator prop

screenshot-127 0 0 1_3000-2023 09 28-11_25_34

screenshot-127 0 0 1_3000-2023 09 28-11_27_13

How to test? Steps to confirm the desired behavior:

  1. Go to /kits/table/rails?sort=firstname_asc#table-header
  2. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • [😈] TESTS I have added test coverage to my code.

@markdoeswork markdoeswork added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Sep 27, 2023
@markdoeswork markdoeswork marked this pull request as ready for review September 27, 2023 16:14
@markdoeswork markdoeswork requested a review from a team as a code owner September 27, 2023 16:14
@app-milano app-milano bot temporarily deployed to pr2766 September 27, 2023 16:34 Inactive
@app-milano app-milano bot temporarily deployed to pr2766 September 27, 2023 18:08 Inactive
@markdoeswork markdoeswork changed the title Make style improvements [PBNTR-95] Make style improvements Sep 27, 2023
@app-milano app-milano bot temporarily deployed to pr2766 September 28, 2023 11:50 Inactive
@markdoeswork markdoeswork self-assigned this Sep 28, 2023
@app-milano app-milano bot temporarily deployed to pr2766 September 28, 2023 15:43 Inactive
@app-milano app-milano bot temporarily deployed to pr2766 September 28, 2023 16:40 Inactive
@app-milano app-milano bot temporarily deployed to pr2766 September 28, 2023 19:03 Inactive
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Sep 28, 2023
@nidaqg nidaqg added this pull request to the merge queue Sep 29, 2023
Merged via the queue into master with commit 852a04f Sep 29, 2023
1 check passed
@nidaqg nidaqg deleted the pbntr/95_improvements_for_nitro_implementation branch September 29, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants