-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBNTR-95] Make style improvements #2766
Merged
nidaqg
merged 15 commits into
master
from
pbntr/95_improvements_for_nitro_implementation
Sep 29, 2023
Merged
[PBNTR-95] Make style improvements #2766
nidaqg
merged 15 commits into
master
from
pbntr/95_improvements_for_nitro_implementation
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdoeswork
added
milano
20 MAX - Deploy this PR to a review environment via Milano
improvement
This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG))
labels
Sep 27, 2023
jasoncypret
reviewed
Sep 27, 2023
playbook/app/pb_kits/playbook/pb_table/styles/_table_header.scss
Outdated
Show resolved
Hide resolved
playbook/app/pb_kits/playbook/pb_table/styles/_table_header.scss
Outdated
Show resolved
Hide resolved
playbook/app/pb_kits/playbook/pb_table/styles/_table_header.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Jason Cypret <[email protected]>
Co-authored-by: Jason Cypret <[email protected]>
Co-authored-by: Jason Cypret <[email protected]>
markdoeswork
changed the title
Make style improvements
[PBNTR-95] Make style improvements
Sep 27, 2023
nidaqg
added
the
Ready for Release
merged to master, ready for a versioned released
label
Sep 28, 2023
nidaqg
approved these changes
Sep 28, 2023
jasperfurniss
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG))
milano
20 MAX - Deploy this PR to a review environment via Milano
Ready for Release
merged to master, ready for a versioned released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Runway: https://nitro.powerhrg.com/runway/backlog_items/PBNTR-95
Feedback provided for a Nitro PR, but the changes need to be made in playbook
Nitro review env: https://pr34778.nitro-web.beta.px.powerapp.cloud/project_surveys/surveys?mt=Customer+Survey+Results
Nitro Web PR: https://github.com/powerhome/nitro-web/pull/34778
Updated the Nav kit to hide the left border indicator when active with the
active_indicator
propHow to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.