Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1026] Homepage Responsiveness Updates #2786

Merged
merged 3 commits into from
Oct 17, 2023
Merged

[PLAY-1026] Homepage Responsiveness Updates #2786

merged 3 commits into from
Oct 17, 2023

Conversation

gavhuang
Copy link
Contributor

@gavhuang gavhuang commented Oct 13, 2023 •
edited
Loading

What does this PR do?

  • Runway
  • Update homepage breakpoints to account for the sidebar updates

Screenshots:

1050px width
Screenshot 2023-10-13 at 3 28 11 PM

1440px width
1440px

How to test? Steps to confirm the desired behavior:

  1. Go to Playbook's homepage
  2. Test the responsiveness of the homepage between 1200-1600px

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@gavhuang gavhuang added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Oct 13, 2023
@gavhuang gavhuang self-assigned this Oct 13, 2023
@gavhuang gavhuang requested a review from a team as a code owner October 13, 2023 19:36
@app-milano app-milano bot temporarily deployed to pr2786 October 13, 2023 19:45 Inactive
@app-milano app-milano bot temporarily deployed to pr2786 October 17, 2023 16:57 Inactive
@jasperfurniss jasperfurniss added this pull request to the merge queue Oct 17, 2023
Merged via the queue into master with commit 9b7b0db Oct 17, 2023
5 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1026-Homepage-Responsiveness branch October 17, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@gavhuang gavhuang

Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavhuang @jasperfurniss