Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBNTR-212] Table Kit Sub Components for Rails #3198

Merged
merged 12 commits into from
Mar 11, 2024
Merged

[PBNTR-212] Table Kit Sub Components for Rails #3198

merged 12 commits into from
Mar 11, 2024

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Mar 1, 2024 •
edited
Loading

What does this PR do?

RUNWAY STORY

  • Creates the following subcomponents for the rails side of the Table kit:

    • table/table_body (Maps to tbody element)
    • table/table_head (Maps to thead element)
    • table/table_cell (Maps to td element)

  • Updates the following existing subcomponents to work with new structure:

    • table/table_header (Maps to th element)
    • table/table_row (Maps to tr element)

  • Creates the tag prop on all subcomponents to allow for use as table element or div with classname.

Screenshots:

Screenshot 2024-03-01 at 1 40 49 PM Screenshot 2024-03-01 at 1 40 55 PM

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Mar 1, 2024
@nidaqg nidaqg self-assigned this Mar 1, 2024
@nidaqg nidaqg marked this pull request as ready for review March 4, 2024 17:34
@nidaqg nidaqg requested review from a team as code owners March 4, 2024 17:34
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-212-table-kit-subcomponents-rails

@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Mar 8, 2024
nickamantia
nickamantia approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@nickamantia nickamantia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@jasperfurniss jasperfurniss added this pull request to the merge queue Mar 11, 2024
Merged via the queue into master with commit a33e52c Mar 11, 2024
5 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-212-table-kit-subcomponents-rails branch March 11, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickamantia nickamantia nickamantia approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@carloslimasd carloslimasd carloslimasd approved these changes

Assignees

@nidaqg nidaqg

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nidaqg @carloslimasd @jasperfurniss @nickamantia @co1in-1ewis