Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-238] Fix for DatePicker Year Bug #3268

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Mar 21, 2024

What does this PR do?

Runway Story

Date Picker default date variant's selected year did not match the days/contents of the visible month in the calendar
This PR implements this solution proposed by MT

Screenshots:

Screenshot 2024-03-21 at 1 57 04 PM

How to test? Steps to confirm the desired behavior:

  1. Open a date range picker with Default Date variant
  2. Change the year to 2020
  3. Select a date then click out of the picker
  4. Open it again and select a date
  5. You should see the correct year displayed

@nidaqg nidaqg added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Mar 21, 2024
@nidaqg nidaqg self-assigned this Mar 21, 2024
@nidaqg nidaqg requested review from a team as code owners March 21, 2024 17:58
@nidaqg nidaqg requested a review from mterezac March 21, 2024 18:01
@nidaqg nidaqg added the alpha label Mar 21, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.21.0.pre.alpha.PBNTR238DatePickerYearBug2436

Your Alpha for NPM is 13.21.0-alpha.PBNTR238DatePickerYearBug2436

@nidaqg nidaqg changed the title [PBNTR-238] Fix for DatePicker Year Gug [PBNTR-238] Fix for DatePicker Year Bug Mar 21, 2024
@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Mar 22, 2024
@thestephenmarshall thestephenmarshall added this pull request to the merge queue Mar 22, 2024
Merged via the queue into master with commit 161e01b Mar 22, 2024
8 checks passed
@thestephenmarshall thestephenmarshall deleted the PBNTR-238-DatePicker-Year-Bug branch March 22, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants