[PLAY-1203] Default cancel and close button type to prevent submission #3273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a form is used to wrap the Rails dialog kit block area content, any unspecified
button
element will submit the form. Only buttons specified with thetype="submit"
attribute should perform this function.By defaulting the cancel and close (X) buttons in the Rails version of the kit, we can avoid this unintended side effect.
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
?
at the end of the URL in the browser's address bar)Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.