[PLAY-1178] Fixed Styling when Select Kit is used within a Flex Kit #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperfurniss
added
milano
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 13.27.0.pre.alpha.PLAY11782916 Your Alpha for NPM is 13.27.0-alpha.PLAY11782916 |
jasperfurniss
changed the title
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 13.27.0.pre.alpha.PLAY11782918 Your Alpha for NPM is 13.27.0-alpha.PLAY11782918 |
nidaqg
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
This allows the dev more fine-grained control over the elements inside of our Select kit, and enables them to move things around using our global spacing props-- which in turn, fixes a bug where the Select kit is broken when nested inside of a Flex kit.
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
https://codesandbox.io/p/sandbox/funny-booth-rqd9dq
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.