Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1667] Dark Mode Audit - Nav #3950

Merged
merged 6 commits into from
Dec 9, 2024
Merged

[PLAY-1667] Dark Mode Audit - Nav #3950

merged 6 commits into from
Dec 9, 2024

Conversation

Tomm1128
Copy link
Contributor

@Tomm1128 Tomm1128 commented Nov 25, 2024 •
edited
Loading

What does this PR do? A clear and concise description with your runway ticket url.

Updates to dark mode styling based on audit for the Nav component.

PLAY-1667

Screenshots: Screenshots to visualize your addition/change

Screenshot 2024-11-25 at 3 17 05 PM

Screenshot 2024-11-25 at 3 21 51 PM

Screenshot 2024-11-25 at 3 20 01 PM

How to test? Steps to confirm the desired behavior:

  1. Go to kits/nav
  2. Turn on Dark Mode
  3. Look at Default Variant, bold horizontal and vertical variants, and collapsible variant
  4. Check both react and rails versions for changes mentioned in the story card

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@Tomm1128 Tomm1128 added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) minor Semver Target labels Nov 25, 2024
@Tomm1128 Tomm1128 self-assigned this Nov 25, 2024
@Tomm1128 Tomm1128 requested a review from a team as a code owner November 25, 2024 20:30
kangaree
kangaree previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@kangaree kangaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

nidaqg
nidaqg previously approved these changes Nov 26, 2024
View reviewed changes
@jasperfurniss jasperfurniss added Code Approved Approved by a Playbook Admin and removed Needs Review labels Nov 26, 2024
@nidaqg nidaqg removed the Code Approved Approved by a Playbook Admin label Nov 27, 2024
@Tomm1128 Tomm1128 dismissed stale reviews from nidaqg and kangaree via 99ec678 December 3, 2024 14:10
@nidaqg nidaqg added Code Approved Approved by a Playbook Admin and removed Needs Review labels Dec 3, 2024
@jasperfurniss jasperfurniss merged commit 0f33085 into master Dec 9, 2024
10 checks passed
@jasperfurniss jasperfurniss deleted the play-1667-nav-dark-mode-audit branch December 9, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangaree kangaree kangaree left review comments

@nidaqg nidaqg nidaqg approved these changes

Assignees

@Tomm1128 Tomm1128

Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tomm1128 @kangaree @nidaqg @jasperfurniss