Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1873] Fix Playbook Gem for Rails 8: Upgrade view_component #4268

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[PLAY-1873] Fix Playbook Gem for Rails 8: Upgrade view_component #4268

wants to merge 2 commits into from
+8 −8

Conversation

kangaree
Copy link
Contributor

@kangaree kangaree commented Feb 12, 2025 •
edited
Loading

What does this PR do?

  • Bump view_component gem from 2.83 to latest, 3.21.0, so activesupport works with Rails 8
    • activesupport (>= 5.2.0, < 8.0) to activesupport (>= 5.2.0, < 8.1)
  • Fix bug that appears in User Badge kit for instance method
    • undefined method `source_location' for class Playbook::PbUserBadge::UserBadge

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@kangaree kangaree added improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) alpha major Semver Target labels Feb 12, 2025
@kangaree kangaree requested a review from a team as a code owner February 12, 2025 15:51
@kangaree kangaree marked this pull request as draft February 12, 2025 15:53
@github-actions GitHub Actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.13.0.pre.alpha.PLAY1873rails86087

Your Alpha for NPM is 14.13.0-alpha.PLAY1873rails86087

@kangaree kangaree added the milano 20 MAX - Deploy this PR to a review environment via Milano label Feb 12, 2025
@kangaree kangaree changed the title [PLAY-1873] Playbook and Rails 8 [PLAY-1873] Fix Playbook Gem for Rails 8: Upgrade view_component Feb 12, 2025
@kangaree kangaree added minor Semver Target and removed major Semver Target labels Feb 12, 2025
@kangaree kangaree added alpha and removed alpha labels Feb 13, 2025
@github-actions GitHub Actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.13.0.pre.alpha.PLAY1873rails86115

Your Alpha for NPM is 14.13.0-alpha.PLAY1873rails86115

@kangaree kangaree marked this pull request as ready for review February 13, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alpha improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kangaree