[PLAY-1900] Progress Pill Full Width #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1900-progress-pill-width |
yuriyivanenko
added
minor
playbook/app/pb_kits/playbook/pb_progress_pills/_progress_pills.scss
Outdated
Show resolved
Hide resolved
|
@yuriyivanenko It looks great, but i would add a test for each of the prop names (spec and jest). Even if the tests are as simple |
nidaqg
approved these changes
Feb 12, 2025
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.13.0.pre.alpha.play1900progresspillwidth6122 Your Alpha for NPM is 14.13.0-alpha.play1900progresspillwidth6122 |
nidaqg
added
Ready for Release
jasperfurniss
removed
the
milano
|
You merged this pr to master branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
This PR is branched off from PLAY-1884
Story
This PR adds a
full_width_pillprop to Rails & React. With this prop we can make the pills take up 100% of the width of the container that the pills are in.Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.