Add capability to verify maximum statistics of scores #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
commented
Nov 29, 2024
| if (!checkDictionary(importedScore.id, "maximum_statistics", importedScore.ScoreData.MaximumStatistics, referenceScore.MaximumStatistics)) | ||
| { | ||
| Interlocked.Increment(ref fail); | ||
| sqlBuffer.Append($"UPDATE `scores` SET `data` = JSON_SET(`data`, '$.maximum_statistics', CAST('{JsonConvert.SerializeObject(referenceScore.MaximumStatistics)}' AS JSON)) WHERE `id` = {importedScore.id};"); |
There was a problem hiding this comment.
Quoting of the maximum statistics is a bit dodgy here but not super sure how to make it any better... It sorta relies on the json serialisation never outputting a quote which is a bit scary.
This was referenced Nov 29, 2024
smoogipoo
approved these changes
Dec 3, 2024
peppy
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended usage is to fix ppy/osu-web#11697, after ppy/osu#30917 is merged, deployed as part of
osu-difficulty-calculator, and legacy scoring attributes are recomputed.Explanation of the failure mode here that links
maximum_statisticswith the linked issue is in the OP of the issue.I've tested this full-stack on my local osu-web instance, but probably best to exercise care.