Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistical accuracy PP and difficulty scaling for the osu!taiko ruleset #20963

Merged
merged 42 commits into from
Oct 7, 2024

Merge branch 'master' into taikostatacc

84d6467
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Statistical accuracy PP and difficulty scaling for the osu!taiko ruleset #20963

Merge branch 'master' into taikostatacc
84d6467
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, MultiThreaded) failed Oct 7, 2024 in 1s

10552 passed, 2 failed and 74 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

10628 tests were completed in 3097s with 10552 passed, 2 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations 10✅ 2❌ 32s

❌ osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations

❌ TestBestRulesetIsRecommended
	"recommended beatmap displayed" timed out
✅ TestBestRulesetIsRecommended
✅ TestConstructor
✅ TestConstructor
✅ TestCorrectStarRatingIsUsed
✅ TestCorrectStarRatingIsUsed
✅ TestCurrentRulesetIsRecommended
✅ TestCurrentRulesetIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestSecondBestRulesetIsRecommended
❌ TestSecondBestRulesetIsRecommended
	"recommended beatmap displayed" timed out

Annotations

Check failure on line 541 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations ► TestBestRulesetIsRecommended

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  "recommended beatmap displayed" timed out
Raw output
"recommended beatmap displayed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 541
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 541 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations ► TestSecondBestRulesetIsRecommended

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  "recommended beatmap displayed" timed out
Raw output
"recommended beatmap displayed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 541
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)