Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path control points losing curve type on save/reload or undo #29446

Merged
merged 4 commits into from
Sep 2, 2024

add back protection against perfect curve segments with > 3 points

eefd7cf
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix path control points losing curve type on save/reload or undo #29446

add back protection against perfect curve segments with > 3 points
eefd7cf
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, MultiThreaded) failed Aug 21, 2024 in 0s

10358 passed, 1 failed and 74 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

10433 tests were completed in 2992s with 10358 passed, 1 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations 11✅ 1❌ 23s

❌ osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations

✅ TestBestRulesetIsRecommended
✅ TestBestRulesetIsRecommended
✅ TestConstructor
✅ TestConstructor
❌ TestCorrectStarRatingIsUsed
	"recommended beatmap displayed" timed out
✅ TestCorrectStarRatingIsUsed
✅ TestCurrentRulesetIsRecommended
✅ TestCurrentRulesetIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestSecondBestRulesetIsRecommended
✅ TestSecondBestRulesetIsRecommended

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations ► TestCorrectStarRatingIsUsed

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  "recommended beatmap displayed" timed out
Raw output
"recommended beatmap displayed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)