Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new queue problem #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added new queue problem #419

wants to merge 1 commit into from

Conversation

Varun270
Copy link

@Varun270 Varun270 commented Feb 8, 2021

Description

Please include a summary of the change and which issue is fixed or what question/feature you have added.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/question
  • This change requires a documentation update
  • Bookmark link

Checklist:

  • My code follows the style guidelines of this project i.e. Pep8
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have squashed unnecessary commits

@Varun270
Copy link
Author

Varun270 commented Feb 8, 2021

This is my first time contributing to open source please do correct me if I make any mistake.

@Varun270
Copy link
Author

Hello, @prabhupant I have added a new queue problem please merge my pull request.

@Varun270
Copy link
Author

Varun270 commented Mar 3, 2021

@prabhupant I have added a new queue problem please merge my pull request.

Copy link
Owner

@prabhupant prabhupant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you adding a new file for basic implementation of queue? Also, as this is a 2 stack implementation of queue, it would be better to rename the file accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants