Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extra volume mounts to be configured #115

Closed
leapsky opened this issue Mar 9, 2021 · 1 comment
Closed

Allow extra volume mounts to be configured #115

leapsky opened this issue Mar 9, 2021 · 1 comment

Comments

@leapsky
Copy link
Contributor

leapsky commented Mar 9, 2021 •
edited
Loading

Description

Bookkeeper operator should allow to specify "extra" volumes to be mounted into a bookie container.

Importance

This functionality is needed to share directories between the hosts and containers, store logs and crash dumps.

Location

pkg/controller/bookkeepercluster/bookie.go
@leapsky leapsky mentioned this issue Mar 9, 2021
Merged
anishakj pushed a commit that referenced this issue Mar 16, 2021
@leapsky
Allow extra volume mounts to be configured #115 (#116)
02276a9 
* Allow extra volume mounts to be configured

* * Renamed extraVolumeMounts to hostPathVolumeMounts.
* Added emptyDirVolumeMounts to support emptyDir volumes. The emptyDirVolumeMounts option is implemented in a manner similar to hostPathVolumeMounts.
* Removed the heapDump volumes. Now we can use emptyDirVolumeMounts.

* Add heapDumpDir as an emptyDir volume if user did not set emptyDirVolumeMounts

* Unit tests for hostPathVolumeMounts and emptyDirVolumeMounts
@anishakj
Copy link
Contributor

Fixed by PR #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leapsky @anishakj