Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 209: Added fix to configure upgrade timeout #210

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

anishakj
Copy link
Contributor

Signed-off-by: anisha.kj [email protected]

Change log description

Added a new field upgradeTimeout in CRD to configure the time

Purpose of the change

Fixes #209

What the code does

Made changes to configure upgrade time

How to verify it

Verified bookkeeper upgrade by configuring upgrade time

@anishakj anishakj requested a review from nishant-yt June 13, 2022 07:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #210 (d1056ff) into master (ca7eb27) will increase coverage by 0.11%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   79.42%   79.54%   +0.11%     
==========================================
  Files          11       11              
  Lines        1847     1848       +1     
==========================================
+ Hits         1467     1470       +3     
+ Misses        295      293       -2     
  Partials       85       85              
Impacted Files Coverage Δ
controllers/upgrade.go 72.64% <50.00%> (-0.35%) ⬇️
api/v1alpha1/bookkeepercluster_types.go 96.00% <100.00%> (+0.04%) ⬆️
pkg/util/zookeeper_util.go 25.00% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca7eb27...d1056ff. Read the comment docs.

controllers/upgrade.go Outdated Show resolved Hide resolved
@anishakj anishakj merged commit 9488079 into master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookkeeper upgrade is failing in slow environments
3 participants