Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 150: Fix for updating bookkeeper spec parameters #217

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

anishakj
Copy link
Contributor

@anishakj anishakj commented Aug 8, 2022

Signed-off-by: anisha.kj [email protected]

Change log description

Currently sts spec parameters are not updatable at runtime. Added support to restart sts pods, if any of the sts fields are changed by editing the bk cluster

Purpose of the change

Fixes #150

What the code does

Added support to modify sts fields at runtime. If the fields are changed, operator will initiate restart of pods

How to verify it

Verified by changing the fields. All the bookie pods are getting restarted one by one.

@anishakj anishakj requested a review from nishant-yt August 8, 2022 05:20
@codecov-commenter
Copy link

Codecov Report

Merging #217 (d2634ca) into master (1a09a2d) will decrease coverage by 0.36%.
The diff coverage is 39.13%.

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage   79.42%   79.05%   -0.37%     
==========================================
  Files          11       11              
  Lines        1852     1872      +20     
==========================================
+ Hits         1471     1480       +9     
- Misses        296      303       +7     
- Partials       85       89       +4     
Impacted Files Coverage Δ
controllers/bookkeepercluster_controller.go 49.13% <39.13%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@nishant-yt nishant-yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to Go

@anishakj anishakj merged commit c797aab into master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many Bookkeeper Spec parameters are not updatable at runtime
3 participants