Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 220: Fix for intermittent bookkeeper cluster upgrade failure #237

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

anishakj
Copy link
Contributor

Change log description

Fixing intermittent upgrade failure of bookkeeper.
Added some more conditions to handle error scenarios

Purpose of the change

Fixes #220

What the code does

while during bookkeeper update, it fails to get the pod sometimes. Issue is happening because while it tries to get an outdated pod, it has already updated. So added more checks to post error only if all pods were not updated

How to verify it

Peformed upgrade multiple time and issue is not seen

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5257dd4) 78.84% compared to head (24be144) 78.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   78.84%   78.59%   -0.26%     
==========================================
  Files          11       11              
  Lines        1872     1878       +6     
==========================================
  Hits         1476     1476              
- Misses        307      313       +6     
  Partials       89       89              
Files Coverage Δ
controllers/upgrade.go 68.94% <0.00%> (-1.95%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anishakj anishakj requested a review from Amit-Singh40 October 11, 2023 08:31
Copy link
Contributor

@Amit-Singh40 Amit-Singh40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit b80fb7c into master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bookkeeper cluster upgrade is failing intermittently
3 participants