Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 97: Providing upgrade path to a test version #98

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Jan 8, 2021

Signed-off-by: SrishT [email protected]

Change log description

This PR adds support to supply a custom upgrade path, which would enable testing the installation and upgrade of the bookkeeper cluster to non-released test versions.

Purpose of the change

Fixes #97

What the code does

When the user enables testmode and provides both the fromVersion and toVersion inside the values.yaml, it does either of the following :

  • if an entry corresponding to the fromVersion is already present in the bk-supported-versions configmap, the entry corresponding to the fromVersion in the bk-supported-versions configmap is replaced with a fresh entry which provides an upgrade path from fromVersion to toVersion
  • if no entry corresponding to the fromVersion exists in the bk-supported-versions configmap, a new entry is created which provides an upgrade path from fromVersion to toVersion

Also when the user enables testmode and specifies just the fromVersion, a new entry is created in the bk-supported-versions configmap, which allows this version to be installed

How to verify it

  • Inside the values.yaml, set the value of testmode.enabled to true and provide values for testmode.fromVersion and testmode.toVersion. You should be able to see an entry of the following format added to the bk-supported-version configmap
<fromVersion> : <fromVersion> , <toVersion>
  • set the value of testmode.enabled to true and provide a value only for testmode.fromVersion and leave testmode.toVersion as is. You should be able to see an entry of the following format added to the bk-supported-version configmap
<fromVersion> : <fromVersion>
  • set the value of testmode.enabled to false. In this case you should not see any changes in the contents of the bk-supported-version configmap

@codecov-io
Copy link

Codecov Report

Merging #98 (fbdc657) into master (4c5189c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   81.45%   81.45%           
=======================================
  Files           9        9           
  Lines        1483     1483           
=======================================
  Hits         1208     1208           
  Misses        218      218           
  Partials       57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5189c...fbdc657. Read the comment docs.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 4957467 into master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to provide a custom upgrade path to a test version
3 participants