Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue-135] Change the usage of ControllerImpl #136

Merged
merged 1 commit into from
Sep 28, 2020
Merged

[issue-135] Change the usage of ControllerImpl #136

merged 1 commit into from
Sep 28, 2020

Conversation

crazyzhou
Copy link
Contributor

Change log description

  • Update the Pravega client
  • Change the usage of ControllerImpl

Purpose of the change
Fixes #135

What the code does

  • Update the Pravega client to 0.8.0 RC1
  • Remove the usage of ControllerImpl in SetupUtils
  • Change the import package of the ControllerImpl in PravegaInputFormatITCase

How to verify it
./gradlew clean build passes

maddisondavid
maddisondavid approved these changes Sep 28, 2020
View reviewed changes
Copy link

@maddisondavid maddisondavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazyzhou crazyzhou merged commit 31c3549 into pravega:master Sep 28, 2020
@crazyzhou crazyzhou deleted the issue-135 branch September 28, 2020 08:05
crazyzhou added a commit that referenced this pull request Sep 30, 2020
@crazyzhou
[issue-135] Change the usage of ControllerImpl (#136)
62f9991 
Signed-off-by: Brian Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddisondavid maddisondavid maddisondavid approved these changes

@RaulGracia RaulGracia Awaiting requested review from RaulGracia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the usage of ControllerImpl
2 participants
@crazyzhou @maddisondavid