Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend functionality of Test Mode to enable privileged mode for Segment Store containers #507

Closed
leapsky opened this issue Feb 16, 2021 · 1 comment

Comments

@leapsky
Copy link
Contributor

leapsky commented Feb 16, 2021

Description

By default, Docker containers run in unprivileged mode. However, to profile the applications, we use tracers (e.g. perf_events, strace, ebpf programs) that requires more sufficient privileges. We need to extend functionality of Test Mode to enable privileged mode for Segment Store containers which will grant them operating system administrative capabilities

Importance

This functionally will allow us to use Linux tracing tools without patching Pravega Operator and make profiling more simple.

Location

pkg/controller/pravega/pravega_segmentstore.go

Suggestions for an improvement

Enable docker container privileged mode in Test Mode

leapsky pushed a commit to leapsky/pravega-operator that referenced this issue Feb 16, 2021
leapsky pushed a commit to leapsky/pravega-operator that referenced this issue Feb 16, 2021
leapsky pushed a commit to leapsky/pravega-operator that referenced this issue Mar 3, 2021
leapsky pushed a commit to leapsky/pravega-operator that referenced this issue Mar 3, 2021
anishakj pushed a commit that referenced this issue Mar 3, 2021
#508)

* Extend functionality of Test Mode to enable privileged mode for Segment Store containers #507

Signed-off-by: Pavel Lipsky <[email protected]>

* Revert "Extend functionality of Test Mode to enable privileged mode for Segment Store containers #507"

This reverts commit 265ec03.

* Add the privileged property to segmentStoreSecurityContext

* Extend functionality of Test Mode to enable privileged mode for Segment Store containers #507

* Fix the formatting

* Revert "Add the privileged property to segmentStoreSecurityContext"

This reverts commit dd3bf15.

Co-authored-by: Pavel Lipsky <[email protected]>
Co-authored-by: Pavel Lipsky <[email protected]>
@anishakj
Copy link
Contributor

Fixed by PR #508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants