Issue 116: Use IP address as Bookie ID

[adrianmo]

Change log description

• Change Bookie ID from using the pod's hostname to the IP address.

Purpose of the change

Related to #116

This is a temporary workaround to fix BookKeeper failover scenarios until Pravega's BookKeeper version is updated to 4.7 (WiP: pravega/pravega#3192).

How to test

BookieFailoverTest should pass.

---

Signed-off-by: Adrián Moreno [email protected]

[adrianmo]

@shrids can you please test the BookieFailoverTest using a custom operator image build based on this branch?

[adrianmo]

I've build an image containing the changes in this PR and pushed it to adrianmo/pravega-operator:issue-116 to make it easier to validate the fix.

[RaulGracia]

I tested this change in a system test build and is taking effect:

2019-01-14 11:36:47,813 4392906 [bookkeeper-io-1] DEBUG o.a.b.proto.PerChannelBookieClient - Successfully wrote request for adding entry: 30022 ledger-id: 12 bookie: 10.200.34.91/10.200.34.91:3181 entry length: 219
2019-01-14 11:36:47,813 4392906 [bookkeeper-io-0] DEBUG o.a.b.proto.PerChannelBookieClient - Successfully wrote request for adding entry: 30022 ledger-id: 12 bookie: 10.200.85.71/10.200.85.71:3181 entry length: 219
2019-01-14 11:36:47,813 4392906 [bookkeeper-io-0] DEBUG o.a.b.proto.PerChannelBookieClient - Successfully wrote request for adding entry: 30022 ledger-id: 12 bookie: 10.200.61.77/10.200.61.77:3181 entry length: 219

Now IPs are used instead of hostnames. BookieFailoverTest is still failing, but the problem is the MinimumBookkeeperReplicas = 3 constant defined, which makes it impossible to downscale the number of Bookies to 2 and the test timeouts.

[RaulGracia]

The change takes effect in a system test build.

[eolivelli]

Makes sense