Issue 187: Webhook rejects requests when cluster is upgrading #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wenqimou <[email protected]>
adrianmo
suggested changes
May 21, 2019
pkg/webhook/webhook.go
Outdated
| @@ -60,6 +62,10 @@ func (pwh *pravegaWebhookHandler) Handle(ctx context.Context, req admissiontypes | |||
| } | |||
| copy := pravega.DeepCopy() | |||
|
|
|||
| if err := pwh.clusterIsAvailable(ctx, copy); err != nil { | |||
| return admission.ErrorResponse(http.StatusBadRequest, err) | |||
There was a problem hiding this comment.
I believe that, in this case, we should return a server error (5xx) instead of a user error (4xx). BadRequest is telling the user that the request is malformed, which is not the case, it's just that the cluster status does not allow this type of request temporarily.
added 2 commits
May 21, 2019 11:05
Signed-off-by: wenqimou <[email protected]>
Signed-off-by: wenqimou <[email protected]>
adrianmo
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Enable webhook to reject requests when cluster is upgrading
Purpose of the change
Fix #187
How to test
Unit test should pass
Signed-off-by: wenqimou [email protected]