Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 205: Add WEBHOOK_NAMESPACE to deploy webhook service #206

Closed
wants to merge 1 commit into from
Closed

Issue 205: Add WEBHOOK_NAMESPACE to deploy webhook service #206

wants to merge 1 commit into from

Conversation

Tristan1900
Copy link
Member

@Tristan1900 Tristan1900 commented Jun 3, 2019 •
edited
Loading

Change log description

  1. Add WEBHOOK_NAMESPACE env variable to configure where to deploy the webhook service.
  2. Minimize permission for admissionregistration.k8s.io resource

Now it is necessary for users to specify WEBHOOK_NAMESPACE env variable in the operator yaml file like this

- name: WEBHOOK_NAMESPACE
  valueFrom:
    fieldRef:
      fieldPath: metadata.namespace

Purpose of the change

Fix #205

How to verify it

Tests should pass

Signed-off-by: wenqimou [email protected]

@Tristan1900 Tristan1900 changed the title Add WEBHOOK_NAMESPACE to deploy webhook service Issue 205: Add WEBHOOK_NAMESPACE to deploy webhook service Jun 3, 2019
@Tristan1900 Tristan1900 added the status/invalid This doesn't seem right label Jun 3, 2019
@Tristan1900
Copy link
Member Author

The issue is in the discussion, please do not merge.

@Tristan1900 Tristan1900 removed the status/invalid This doesn't seem right label Jun 26, 2019
@Tristan1900
Copy link
Member Author

Closing this since we agree to continue to use WATCH_NAMESPACE

@pbelgundi
Copy link
Contributor

pbelgundi commented Jul 19, 2019 •
edited
Loading

Webhook should be in the same namespace as operator and pravega, so there is really no need for a separate env variable here.

@EronWright EronWright mentioned this pull request Jul 26, 2019
Closed
@EronWright EronWright reopened this Jul 26, 2019
@pbelgundi
Copy link
Contributor

This is not needed any more as the root cause is fixed.

@pbelgundi pbelgundi closed this Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbelgundi pbelgundi Awaiting requested review from pbelgundi

@SrishT SrishT Awaiting requested review from SrishT

@jkhalack jkhalack Awaiting requested review from jkhalack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pravega-operator pod crashing if WATCH_NAMESPACE not set
3 participants
@Tristan1900 @pbelgundi @EronWright