Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 184: DESIRED VERSION field from kubectl get PravegaCluster is blank during upgrade #232

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Jul 12, 2019

Signed-off-by: SrishT [email protected]

Change log description

When upgrading a Pravega Cluster in operator 0.4.0, the DESIRED VERSION field is obtained as an empty field during entire upgrade process.

$ kubectl get pravegacluster
NAME           VERSION              DESIRED VERSION   DESIRED MEMBERS   READY MEMBERS   AGE
bar-pravega    0.5.0-2222.8ba5431                     5                 5               4m

Purpose of the change

Fixes #184

What the code does

The code populates the DESIRED VERSION field with the appropriate value

How to verify it

To reproduce the issue tried upgrading a sample Pravega Cluster from version 0.5.0-2222.8ba5431 to version 0.5.0-2236.5228e2d and then running kubectl get PravegaCluster. The DESIRED VERSION field obtained was blank as mentioned in the issue.
Created a new operator image with the fix and confirmed that the error reported in the issue is not noticed after the fix. The following result is obtained after the fix has been applied :-

$ kubectl get PravegaCluster
NAME          VERSION              DESIRED VERSION      DESIRED MEMBERS   READY MEMBERS   AGE
bar-pravega   0.5.0-2222.8ba5431   0.5.0-2236.5228e2d   5                 5               6m

@SrishT SrishT requested a review from pbelgundi July 12, 2019 10:35
@pbelgundi
Copy link
Contributor

pbelgundi commented Jul 15, 2019

This only fixes the helm chart. Please fix "crd.yaml" in deploy folder as well and publish test results for the same in this PR.

@SrishT
Copy link
Contributor Author

SrishT commented Jul 15, 2019

Made the fix inside crd.yaml inside the deploy folder and tested the fix by deploying the Pravega Operator and the Pravega Cluster using this approach.
The following result is obtained after the fix has been applied :-

$ kubectl get PravegaCluster
NAME      VERSION              DESIRED VERSION      DESIRED MEMBERS   READY MEMBERS   AGE
pravega   0.5.0-2222.8ba5431   0.5.0-2236.5228e2d   7                 7               4m

Copy link
Contributor

@pbelgundi pbelgundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbelgundi pbelgundi merged commit 27def57 into master Jul 15, 2019
@Tristan1900 Tristan1900 deleted the issue-184-include-desired-version-field branch September 18, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"DESIRED VERSION" field from "kubectl get PravegaCluster" is blank during upgrade
2 participants