Issue 205,217: Add additional README guide for manual deployment and upgrade #236
Conversation
Signed-off-by: wenqimou <[email protected]>
Signed-off-by: wenqimou <[email protected]>
Signed-off-by: wenqimou <[email protected]>
Signed-off-by: wenqimou <[email protected]>
Signed-off-by: wenqimou <[email protected]>
Makefile
Outdated
| @@ -53,7 +53,7 @@ run-local: | |||
| operator-sdk up local --operator-flags -webhook=false | |||
|
|
|||
| login: | |||
| @docker login -u "$(DOCKER_USER)" -p "$(DOCKER_PASS)" | |||
| @docker login -u "$(DOCKER_TEST_USER)" -p "$(DOCKER__TEST_PASS)" | |||
There was a problem hiding this comment.
How does this name change help?
There was a problem hiding this comment.
This doesn't, I just use a different name to avoid deleting your DOCKER_USER and DOCKER_PASS in the Travis setting.
doc/troubleshooting.md
Outdated
| be deleted by Deployment controller. | ||
|
|
||
| ## WATCH_NAMESPACE not set |
There was a problem hiding this comment.
I see that there is a way to get the "current namespace" in which the operator is running:
https://github.com/operator-framework/operator-sdk/blob/master/pkg/k8sutil/k8sutil.go#L63
Lets use this as the 'namespace' for pravega and webhook service, instead of using WATCH_NAMESPACE.
There was a problem hiding this comment.
Conceptually, there are really 2 namespaces involved here - one in which the operator runs and the other that the operator "watches". Irrespective of what are the WATCH_NAMESPACES for operator, it should always install pravega and the webhook in the same namespace where it itself runs.
There was a problem hiding this comment.
Thanks! This looks very helpful, let me try it out to see if it works.
Signed-off-by: wenqimou <[email protected]>
Signed-off-by: wenqimou <[email protected]>
Signed-off-by: wenqimou <[email protected]>
Signed-off-by: wenqimou <[email protected]>
Signed-off-by: wenqimou <[email protected]>
|
After setting webhook namespace to "current" namespace of operator, it should work with WATCH_NAMESPACE="" in the chart or manifest file. |
|
It works when using that util function without passing |
Signed-off-by: wenqimou [email protected]
Change log description
Add additional README for manual deployment and upgrade.
Purpose of the change
Fix #205 #217