Issue 226: Pass jvm options

example/cr-detailed.yaml

@@ -62,6 +62,13 @@ spec:
       # Default is 60
       codahaleStatsOutputFrequencySeconds: "30"
 
+    # Pass the JVM options to Bookkeeper
+    jvm:
+      memoryOpts: ["-Xms2g", "-XX:MaxDirectMemorySize=2g"]
+      gcOpts: ["-XX:MaxGCPauseMillis=20"]
+      gcLoggingOpts: ["-XX:NumberOfGCLogFiles=10"]
+      extraOpts: []
+
   pravega:
     image:
       repository: pravega/pravega
@@ -134,3 +141,8 @@ spec:
       pravegaservice.enableTls: "true"
       pravegaservice.certFile: "/etc/secret-volume/segmentStore01.pem"
       pravegaservice.keyFile: "/etc/secret-volume/segmentStore01.key.pem"
+
+    # Pass the JVM options to controller and segmentstore
+    jvm:
+      controller: ["-XX:MaxDirectMemorySize=1g"]
+      segmentstore: ["-XX:MaxDirectMemorySize=1g"]

pkg/apis/pravega/v1alpha1/bookkeeper.go

@@ -82,6 +82,11 @@ type BookkeeperSpec struct {
 	// in bookkeeper. Some examples can be found here
 	// https://github.com/apache/bookkeeper/blob/master/docker/README.md
 	Options map[string]string `json:"options"`
+
+	// JVM is the JVM options for bookkeeper. It will be passed to the JVM for performance tuning.
+	// If this field is not specified, the operator will use a set of default
+	// options that is good enough for general deployment.
+	JVM *BookkeeperJVMOptions `json:"jvm"`
 }
 
 func (s *BookkeeperSpec) withDefaults() (changed bool) {
@@ -130,6 +135,10 @@ func (s *BookkeeperSpec) withDefaults() (changed bool) {
 		s.Options = map[string]string{}
 	}
 
+	if s.JVM == nil {
+		s.JVM = &BookkeeperJVMOptions{}
+	}
+
 	return changed
 }
 
@@ -138,6 +147,13 @@ type BookkeeperImageSpec struct {
 	ImageSpec
 }
 
+type BookkeeperJVMOptions struct {
+	MemoryOpts    []string `json:"memoryOpts"`
+	GcOpts        []string `json:"gcOpts"`
+	GcLoggingOpts []string `json:"gcLoggingOpts"`
+	ExtraOpts     []string `json:"extraOpts"`
+}
+
 func (s *BookkeeperImageSpec) withDefaults() (changed bool) {
 	if s.Repository == "" {
 		changed = true

pkg/apis/pravega/v1alpha1/pravega.go

@@ -88,6 +88,11 @@ type PravegaSpec struct {
 	// https://github.com/pravega/pravega/blob/master/config/config.properties
 	Options map[string]string `json:"options"`
 
+	// JVM is the JVM options for controller and segmentstore. It will be passed to the JVM
+	// for performance tuning. If this field is not specified, the operator will use a set of default
+	// options that is good enough for general deployment.
+	JVM *PravegaJVMOptions `json:"jvm"`
+
 	// CacheVolumeClaimTemplate is the spec to describe PVC for the Pravega cache.
 	// This field is optional. If no PVC spec, stateful containers will use
 	// emptyDir as volume
@@ -139,6 +144,13 @@ func (s *PravegaSpec) withDefaults() (changed bool) {
 		s.Options = map[string]string{}
 	}
 
+	if s.JVM == nil {
+		changed = true
+		s.JVM = &PravegaJVMOptions{}
+		s.JVM.Controller = []string{}
+		s.JVM.Segmentstore = []string{}
+	}
+
 	if s.CacheVolumeClaimTemplate == nil {
 		changed = true
 		s.CacheVolumeClaimTemplate = &v1.PersistentVolumeClaimSpec{
@@ -262,3 +274,8 @@ type HDFSSpec struct {
 	Root              string `json:"root"`
 	ReplicationFactor int32  `json:"replicationFactor"`
 }
+
+type PravegaJVMOptions struct {
+	Controller   []string `json:"controller"`
+	Segmentstore []string `json:"segmentstore"`
+}

pkg/controller/pravega/bookie.go

@@ -217,6 +217,7 @@ func MakeBookieConfigMap(pravegaCluster *v1alpha1.PravegaCluster) *corev1.Config
 			"-XX:MaxRAMFraction=2",
 		)
 	}
+	memoryOpts = util.OverrideDefaultJVMOptions(memoryOpts, pravegaCluster.Spec.Bookkeeper.JVM.MemoryOpts)
 
 	gcOpts := []string{
 		"-XX:+UseG1GC",
@@ -230,6 +231,7 @@ func MakeBookieConfigMap(pravegaCluster *v1alpha1.PravegaCluster) *corev1.Config
 		"-XX:+DisableExplicitGC",
 		"-XX:-ResizePLAB",
 	}
+	gcOpts = util.OverrideDefaultJVMOptions(gcOpts, pravegaCluster.Spec.Bookkeeper.JVM.GcOpts)
 
 	gcLoggingOpts := []string{
 		"-XX:+PrintGCDetails",
@@ -239,11 +241,18 @@ func MakeBookieConfigMap(pravegaCluster *v1alpha1.PravegaCluster) *corev1.Config
 		"-XX:NumberOfGCLogFiles=5",
 		"-XX:GCLogFileSize=64m",
 	}
+	gcLoggingOpts = util.OverrideDefaultJVMOptions(gcLoggingOpts, pravegaCluster.Spec.Bookkeeper.JVM.GcLoggingOpts)
+
+	extraOpts := []string{}
+	if pravegaCluster.Spec.Bookkeeper.JVM.ExtraOpts != nil {
+		extraOpts = pravegaCluster.Spec.Bookkeeper.JVM.ExtraOpts
+	}
 
 	configData := map[string]string{
 		"BOOKIE_MEM_OPTS":          strings.Join(memoryOpts, " "),
 		"BOOKIE_GC_OPTS":           strings.Join(gcOpts, " "),
 		"BOOKIE_GC_LOGGING_OPTS":   strings.Join(gcLoggingOpts, " "),
+		"BOOKIE_EXTRA_OPTS":        strings.Join(extraOpts, " "),
 		"ZK_URL":                   pravegaCluster.Spec.ZookeeperUri,
 		"BK_useHostNameAsBookieID": "true",
 		"PRAVEGA_CLUSTER_NAME":     pravegaCluster.ObjectMeta.Name,

pkg/controller/pravega/pravega_controller.go

@@ -171,7 +171,11 @@ func addSecretVolumeWithMount(podSpec *corev1.PodSpec, p *api.PravegaCluster,
 }
 
 func MakeControllerConfigMap(p *api.PravegaCluster) *corev1.ConfigMap {
-	var javaOpts = []string{
+	javaOpts := []string{
+		"-Dpravegaservice.clusterName=" + p.Name,
+	}
+
+	jvmOpts := []string{
 		"-Xms512m",
 		"-XX:+ExitOnOutOfMemoryError",
 		"-XX:+CrashOnOutOfMemoryError",
@@ -182,13 +186,15 @@ func MakeControllerConfigMap(p *api.PravegaCluster) *corev1.ConfigMap {
 
 	if match, _ := util.CompareVersions(p.Spec.Version, "0.4.0", ">="); match {
 		// Pravega < 0.4 uses a Java version that does not support the options below
-		javaOpts = append(javaOpts,
+		jvmOpts = append(jvmOpts,
 			"-XX:+UnlockExperimentalVMOptions",
 			"-XX:+UseCGroupMemoryLimitForHeap",
 			"-XX:MaxRAMFraction=2",
 		)
 	}
 
+	javaOpts = append(javaOpts, util.OverrideDefaultJVMOptions(jvmOpts, p.Spec.Pravega.JVM.Controller)...)
+
 	for name, value := range p.Spec.Pravega.Options {
 		javaOpts = append(javaOpts, fmt.Sprintf("-D%v=%v", name, value))
 	}

pkg/controller/pravega/pravega_segmentstore.go

@@ -160,6 +160,10 @@ func makeSegmentstorePodSpec(p *api.PravegaCluster) corev1.PodSpec {
 
 func MakeSegmentstoreConfigMap(p *api.PravegaCluster) *corev1.ConfigMap {
 	javaOpts := []string{
+		"-Dpravegaservice.clusterName=" + p.Name,
+	}
+
+	jvmOpts := []string{
 		"-Xms1g",
 		"-XX:+ExitOnOutOfMemoryError",
 		"-XX:+CrashOnOutOfMemoryError",
@@ -170,17 +174,18 @@ func MakeSegmentstoreConfigMap(p *api.PravegaCluster) *corev1.ConfigMap {
 
 	if match, _ := util.CompareVersions(p.Spec.Version, "0.4.0", ">="); match {
 		// Pravega < 0.4 uses a Java version that does not support the options below
-		javaOpts = append(javaOpts,
+		jvmOpts = append(jvmOpts,
 			"-XX:+UnlockExperimentalVMOptions",
 			"-XX:+UseCGroupMemoryLimitForHeap",
 			"-XX:MaxRAMFraction=2",
 		)
 	}
 
+	javaOpts = append(javaOpts, util.OverrideDefaultJVMOptions(jvmOpts, p.Spec.Pravega.JVM.Segmentstore)...)
+
 	for name, value := range p.Spec.Pravega.Options {
 		javaOpts = append(javaOpts, fmt.Sprintf("-D%v=%v", name, value))
 	}
-
 	authEnabledStr := fmt.Sprint(p.Spec.Authentication.IsEnabled())
 	configData := map[string]string{
 		"AUTHORIZATION_ENABLED": authEnabledStr,