Issue 289: Adding SegmentStoreSvcAnnotations

[SrishT]

Signed-off-by: SrishT [email protected]

Change log description

SegmentStoreSvcAnnotations added to the manifest file are not visible in the kubectl describe output for the segmentStoreSvc if the domainName field is empty.

Purpose of the change

Fixes #289

What the code does

The code populates the SegmentStoreSvcAnnotations from the manifest file if external access has been enabled.

How to verify it

Add SegmentStoreSvcAnnotations to the manifest file

pravega:
    segmentStoreSvcAnnotations:
      service.beta.kubernetes.io/aws-load-balancer-access-log-s3-bucket-prefix: "abc"

Deploy PravegaCluster with external access enabled. The describe output for the segmentStoreSvc should contain the added segmentStoreSvcAnnotations key-value pairs as part of Annotations field of the output.

$ kubectl describe svc bar-pravega-pravega-segmentstore-0
Name:                     bar-pravega-pravega-segmentstore-0
Namespace:                default
Labels:                   app=pravega-cluster
                          component=pravega-segmentstore
                          pravega_cluster=bar-pravega
Annotations:              ncp/error.loadbalancer: IP_POOL_EXHAUSTED
                          service.beta.kubernetes.io/aws-load-balancer-access-log-s3-bucket-prefix: abc
Selector:                 statefulset.kubernetes.io/pod-name=bar-pravega-pravega-segmentstore-0
Type:                     LoadBalancer
IP:                       10.100.200.55
Port:                     server  12345/TCP
TargetPort:               12345/TCP
NodePort:                 server  30860/TCP
Endpoints:                172.28.78.12:12345
Session Affinity:         None
External Traffic Policy:  Local
HealthCheck NodePort:     31566
Events:                   <none>

[pbelgundi]

Travis build is failing. Could you pls fix that..
Otherwise LGTM.

[pbelgundi]

Please also add a UT for enabling external access and setting domain name alone without setting external svc annotations.

[pbelgundi]

Suggested some improvements to unit tests.

[pbelgundi]

LGTM