Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-322: renamed ECS config item root to prefix #323

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

kevinhan88
Copy link
Contributor

Signed-off-by: kevinhan88 [email protected]

Change log description

The ECS config item "root" is renamed to "prefix" per pravega/pravega#4550
This is the corresponding change in operator.

Purpose of the change

Fixes #322

What the code does

Replaced "root" with "prefix" in the following files:
pravega_segmentstore_test.go
cr-detailed.yaml
pravega_segmentstore.go
pravega.go
tier2.md

How to verify it

The operator should function as usual with the new ECS config item "prefix".

@pbelgundi pbelgundi removed the request for review from SrishT February 13, 2020 05:01
Copy link
Contributor

@pbelgundi pbelgundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this with Kevin and I see that there is no backward compatibility impact.
LGTM.

@kevinhan88 kevinhan88 removed the request for review from Tristan1900 February 14, 2020 06:37
@pbelgundi pbelgundi merged commit 62df794 into pravega:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ECS config item root to prefix
3 participants