Issue 354: Segment store pods are not coming up with external access #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anisha.kj <[email protected]>
pbelgundi
requested changes
Apr 8, 2020
pkg/util/pravegacluster.go
Outdated
| @@ -116,6 +119,14 @@ func StatefulSetNameForSegmentstoreBelow07(name string) string { | |||
| return fmt.Sprintf("%s-pravega-segmentstore", name) | |||
| } | |||
|
|
|||
| func ServiceNameForSegmentStoreBelow07(name string, index int32) string { | |||
There was a problem hiding this comment.
Do we really need these 2 methods?
It would be better to have all the name generation logic in one place inside method "ServiceNameForSegmentStore" and always invoke this method by passing PravegaCluster object as parameter.
Signed-off-by: anisha.kj <[email protected]>
pbelgundi
approved these changes
Apr 9, 2020
|
LGTM |
Prabhaker24
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anisha.kj [email protected]
Change log description
In pravega operator
0.5, we are creating STS with different name that in turn changes pod name. Due to that init script of pravega is failing as it assumes pod name is same service name. And segment containers are not coming up.POD_NAME is passed as env variable from operator to pravega init scriptPurpose of the change
Fixes #354
What the code does
From 0.7 pravega onwards, pod name and external service names were different with 0.5 operator.
Changed external service name to pod name, so that external service name and pod name will have the same name in every pravega version. Also while doing upgrade from 0.6 to 0.7, delete the external services and create services with same name of pravega-0.7 segment store pods.
How to verify it
Tested the below scenarios with external connectivity
All the above scenarios have passed