Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue348: added ECS TLS secret into general pravega tls section #383

Merged
merged 1 commit into from
May 7, 2020

Conversation

anishakj
Copy link
Contributor

@anishakj anishakj commented May 4, 2020

Signed-off-by: anisha.kj [email protected]

Change log description

This PR is cherry-pick of changes in PR #349

Purpose of the change

Fixes #348

What the code does

When ECS certificate is defined as "pravega/tls/static/ca-bundle" inside Pravega yaml file, the operator mounts it onto "/etc/secret-volume/ca-bundle" in Segmentstore container.
Then container adds the certificate into Java Truststore in order to establish secured connection with ECS.

How to verify it

(Steps to verify that the changes are effective)

@anishakj anishakj requested review from pbelgundi and kevinhan88 May 4, 2020 07:31
Copy link
Contributor

@kevinhan88 kevinhan88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@anishakj anishakj merged commit 26a1c03 into 0.4.4 May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants