Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 411: Updating Pravega configuration key names #416

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Jul 3, 2020

Signed-off-by: SrishT [email protected]

Change log description

Modifying the configuration key names mentioned in the operator documentation and sample manifests in accordance with the changes made by this PR on Pravega side.

Purpose of the change

Fixes #411

@SrishT SrishT requested review from ravisharda and anishakj July 3, 2020 13:17
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2020

Codecov Report

Merging #416 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #416   +/-   ##
=======================================
  Coverage   76.07%   76.07%           
=======================================
  Files          14       14           
  Lines        3314     3314           
=======================================
  Hits         2521     2521           
  Misses        705      705           
  Partials       88       88           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302d40a...a99a91d. Read the comment docs.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change field pravegaservice.cacheMaxSize in upgrade-cluster.md and bookkeeper.bkAckQuorumSize in charts/pravega/values.yaml

@SrishT
Copy link
Contributor Author

SrishT commented Jul 6, 2020

Please change field pravegaservice.cacheMaxSize in upgrade-cluster.md and bookkeeper.bkAckQuorumSize in charts/pravega/values.yaml

made the change

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/longtermstorage.md Show resolved Hide resolved
doc/longtermstorage.md Outdated Show resolved Hide resolved
doc/minikube_setup.md Show resolved Hide resolved
example/cr-detailed.yaml Show resolved Hide resolved
@anishakj anishakj merged commit 28b2c5a into master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new Pravega configuration key names in code and documentation
4 participants