-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 411: Updating Pravega configuration key names #416
Conversation
Signed-off-by: SrishT <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 76.07% 76.07%
=======================================
Files 14 14
Lines 3314 3314
=======================================
Hits 2521 2521
Misses 705 705
Partials 88 88 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change field pravegaservice.cacheMaxSize
in upgrade-cluster.md
and bookkeeper.bkAckQuorumSize
in charts/pravega/values.yaml
Signed-off-by: SrishT <[email protected]>
made the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT [email protected]
Change log description
Modifying the configuration key names mentioned in the operator documentation and sample manifests in accordance with the changes made by this PR on Pravega side.
Purpose of the change
Fixes #411