Issue 421: Adding manifests for various cluster installation flavours #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SrishT <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
=======================================
Coverage 76.10% 76.10%
=======================================
Files 14 14
Lines 3318 3318
=======================================
Hits 2525 2525
Misses 705 705
Partials 88 88 Continue to review full report at Codecov.
|
RaulGracia
requested changes
Jul 13, 2020
charts/pravega/values.yaml
Outdated
| @@ -109,4 +109,58 @@ storage: | |||
| className: standard | |||
|
|
|||
| options: | |||
| # bookkeeper.ack.quorum.size: "3" | |||
| ## If you add more Bookies to the cluster and you want to exploit them for IO, then you need increase this number. The Bookkeeper ensemble defines | |||
There was a problem hiding this comment.
Please, remove some of these explanations, I don't think they are needed.
charts/pravega/values.yaml
Outdated
| bookkeeper.write.quorum.size: "3" | ||
| ## By default, we set bookkeeper.write.quorum.size == bookkeeper.ack.quorum.size, so we wait for the ACK of all the Bookies on a write to proceed to the next one. This | ||
| ## has been proven as a factor that makes Pravega much more stable in the long run for IO heavy workloads, at the cost of sacrificing performance. | ||
| ## If we set bkWriteQuorumSize > bkAckQuorumSize, we can improve performance, but a temporarily "slow" Bookie may lead to OOM errors at both the |
There was a problem hiding this comment.
Same here, unnecessary explanations.
Signed-off-by: SrishT <[email protected]>
RaulGracia
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SrishT [email protected]
Change log description
Provides 4 different kinds of manifests (i.e. small, medium, large and minikube) which provide the user more flexibility in deploying a cluster with the required number of component replicas, resources and required options without having to override those values individually.
Purpose of the change
Fixes #421
How to verify it
To install a cluster with the resource requirements that would work on a minikube environment, use the following command
It will successfully install a pravega cluster with the required replicas, resources and options.
Similarly user can give any of the following commands depending on his particular use-case