Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 425: Readinesscheck for only auth added #426

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Conversation

Prabhaker24
Copy link
Contributor

Signed-off-by: prabhaker24 [email protected]

Change log description

ReadinessCheck in case of only auth enabled is added

Purpose of the change

fixes #425

What the code does

It checks if the controller pod is ready in case only auth is enabled.

How to verify it

Deploy pravega cluster with only Auth enabled and check for the controller pod to become ready

@Prabhaker24 Prabhaker24 requested a review from anishakj July 17, 2020 12:42
@codecov-commenter
Copy link

Codecov Report

Merging #426 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   76.10%   76.11%   +0.01%     
==========================================
  Files          14       14              
  Lines        3318     3320       +2     
==========================================
+ Hits         2525     2527       +2     
  Misses        705      705              
  Partials       88       88              
Impacted Files Coverage Δ
pkg/util/pravegacluster.go 97.51% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b6e2e...8a3ef46. Read the comment docs.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit bf5afd9 into master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readines Probe is not working in case of only auth enabled
3 participants